Right now both VoteStorage and VoteResultStorage use \Drupal::entityQuery() to calculate values, instead of using the injected entity query inherited from the parent storage class.

Fix this, and remove the phpstan ignore cases for these uses from phpstan.neon.

Issue fork votingapi-3511838

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tr created an issue. See original summary.

tr’s picture

tr commented

Also type hint everything in the storage classes.

tr opened merge request !54

tr’s picture

tr commented
Status: Active » Needs review

  • tr committed 010514d0 on 4.0.x 
    Issue #3511838 by tr: Use injected entity query in storage classes
tr’s picture

tr commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.