Problem/Motivation

When creating a sub-theme using UI Suite DaisyUI as a base theme, the standard Drupal starter theme generation script, php core/scripts/drupal generate-theme my_daisyui_theme --starterkit ui_suite_daisyui_starterkit --path themes/custom produces a warning stating that the base theme does not have a version number.

Steps to reproduce

With a starterkit theme ready to be cloned and configured under ui_suite_daisyui/starterkits, execute the following code from the web/ folder: php core/scripts/drupal generate-theme my_daisyui_theme --starterkit ui_suite_daisyui_starterkit --path themes/custom

Proposed resolution

Add a version number to the theme yml file

Remaining tasks

Update theme yml file.

User interface changes

Version number will appear on the themes configuration screen.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
info.patch262 bytespaddy_deburca

Issue fork ui_suite_daisyui-3510787

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paddy_deburca created an issue. See original summary.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

The version number is there when you download (end extract) the theme package file or install the theme using composer.

The version number is never part of the git source code.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

If you are installing a dev release with composer, then the version number is missing from the info file. But even then you can use the following composer plugin, to have correct version information.
https://packagist.org/packages/drupal-composer/info-rewrite

rinku jacob 13 made their first commit to this issue’s fork.

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Status: Active » Needs review
Issue tags: +UI Suite Initiative

Hello @paddy_deburca @pasqualle,

Can you please test the new Starterkit feature (#3508143: [5.0.x] Create Starterkit theme with Documentation.) that normally solves this issue ?

Here is the link to the README: https://git.drupalcode.org/project/ui_suite_daisyui/-/blob/5.0.x/starter...

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Title: Missing version number in the theme yml file » [5.0.x] Missing version number in the theme yml file
johanf’s picture

johanf commented

Hello

Starting to test all this ui_pattern and ui_suite environment who seems very interesting
I just test with beta version.
and followed the readme to create a subtheme.
I got this message 'The source theme ui_suite_daisyui_starterkit does not have a version specified. This makes tracking changes in the source theme difficult. Are you sure you want to continue?'

I continue and the result in the info file is

version: 1.0.0
generator: 'ui_suite_daisyui_starterkit:unknown-version'

npm install
npm run build
drush cr

i enabled the modules required
and i get the subtheme

g4mbini opened merge request !152

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented

  • g4mbini committed a01750d9 on 5.0.x 
    Issue #3510787 by g4mbini, paddy_deburca, rinku jacob 13, pasqualle,...
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Status: Needs review » Fixed

Thanks everyone for participating.

Now we have the correct version management inside the starterkit!

Cheers

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.