Problem/Motivation

Not all servers support converting to AVIF, so we can't use it as a default format for image styles in install profiles.

Steps to reproduce

  1. Have a server that doesn't support AVIF
  2. Use the Convert image style plugin configured to use AVIF
  3. Create an article with an image, the image will not display

Proposed resolution

As per #3372932-40: [Meta] High-performance images (nearly) out of the box we may need a new Image Effect to convert to AVIF if it's supported, with a fallback to WEBP if it's not. Possibly this could be generic for other formats too, but for now only AVIF has explicit requirements.

Remaining tasks

  1. Decide if we want to do this
  2. Review the approach in the MR
  3. Make the IS and CR sparkle

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3510582

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !11361

mstrelan’s picture

mstrelan commented
Status: Active » Needs review

Quick PoC of an image effect with fallback format. Setting to NR for feedback on the approach, please don't send it back for tests/lint/CR etc.

mstrelan’s picture

mstrelan commented

Added a test for when AVIF is supported and another test for the fallback. Added a draft CR. This is ready for review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Could the IS get some love. Wouldn't this be considered an API change?

Wonder if a CR is required?

mstrelan’s picture

mstrelan commented
Issue summary: View changes

Updated the IS to hopefully make it clearer. There is already a CR, are you suggesting it might not be necessary? I think it is useful.

mstrelan’s picture

mstrelan commented
Status: Needs work » Needs review
mstrelan’s picture

mstrelan commented

Re #5:

Wouldn't this be considered an API change?

It's a new plugin, not a change to an existing one, so no breakage here. You could argue the change to the protected function in GDToolkit is a BC break, but plugins are considered internal and it's a protected method as well, so I don't think it's an issue.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I find it good/handy feature with CR)

Moreover AVIF is specifically good for big sizes with fallback

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Moreover AVIF is specifically good for big sizes with fallback

Not necessarily in this issue, could maybe be a follow-up, would we want to consider some kind of configurable filesize threshold where below a certain point we always skip AVIF and use webp instead? Have seen various discussions that decoding AVIF in the browser is a lot more expensive than webp, which can undo the bandwidth savings with smaller images.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Opened up #3516434: Consider falling back to webp from AVIF based on filesize for that discussion.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

One comment on the MR.

mstrelan’s picture

mstrelan commented
Status: Needs work » Needs review

Switched to keyvalue instead of state

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

poker10’s picture

poker10 commented

Sorry for asking, maybe it is obvious, but when we added webp format and possible conversion to core and image styles (#3275557: Add webp image conversion to core's install profile's image style and #3406267: All core shipped image styles should include webp conversion), we have not added any fallback. Was webp available in all PHP installations at that time? If not, are we sure that now when avif will not be available, webp will be?

catch’s picture

catch
he/him
Primary language English
commented

@poker10 I am fairly sure that PHP installation support was widespread when webp was added to core. imagewebp from the gd library has been available since PHP 5.4 according to https://www.php.net/manual/en/function.imagewebp.php so theoretically that means it was everywhere.

However there was also an issue that older versions of osx, from around 2015 and earlier would not render webp, regardless of browser. This delayed us enabling webp by default in image styles in core until some time during Drupal 10. So we had it available as an option for a long time before then.

With AVIF it has been somewhat the opposite, in that all the browsers we care about supported it before php did. So once we do this issue, we should be able to convert the default image styles in core and Drupal CMS over, give or take the size considerations in the follow-up.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +11.2.0 release highlights

Tagging for 11.2.0 release highlights, I'll try to review this one more time. Mine was the last RTBC on this issue but not the first two, so I think I'm fine to commit this still.

  • catch committed 8d563697 on 11.2.x 
    Issue #3510582 by mstrelan, catch, smustgrave: AVIF conversion with WEBP...

  • catch committed b92344d4 on 11.x 
    Issue #3510582 by mstrelan, catch, smustgrave: AVIF conversion with WEBP...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!

catch closed merge request !11361

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.