Problem/Motivation

The Migration test is failing.

Steps to reproduce

PHP Fatal error: Declaration of Drupal\Tests\statistics\Functional\migrate_drupal\d6\NoMultilingualReviewPageTest::testMigrateUpgradeReviewPage() must be compatible with Drupal\Tests\migrate_drupal_ui\Functional\NoMultilingualReviewPageTestBase::testMigrateUpgradeReviewPage(): void in /builds/issue/statistics-2962763/tests/src/Functional/migrate_drupal/d6/NoMultilingualReviewPageTest.php on line 46

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork statistics-3510543

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

bluegeek9 opened merge request !9

bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Needs review
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Postponed (maintainer needs more info)

That will need more info : it did not fail on CI during release. What is the environment in which you encounter that failure ?

bluegeek9’s picture

bluegeek9 commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Active

The tests fail on Drupal 11.2. You can see the tests fail in the pipeline below.

https://git.drupalcode.org/issue/statistics-2962763/-/pipelines/438021

PHP Fatal error:  Declaration of Drupal\Tests\statistics\Functional\migrate_drupal\d6\NoMultilingualReviewPageTest::testMigrateUpgradeReviewPage() must be compatible with Drupal\Tests\migrate_drupal_ui\Functional\NoMultilingualReviewPageTestBase::testMigrateUpgradeReviewPage(): void in /builds/issue/statistics-2962763/tests/src/Functional/migrate_drupal/d6/NoMultilingualReviewPageTest.php on line 46
bluegeek9’s picture

bluegeek9 commented

You can schedule pipelines here: https://git.drupalcode.org/project/statistics/-/pipeline_schedules

I recommend testing weekly.

joachim’s picture

joachim commented
Component: Miscellaneous » Code
Category: Task » Bug report
Priority: Normal » Critical

Failing tests are a bug -- they prevent all other work on the code!

joachim’s picture

joachim commented
Title: Migration test failing » Functional tests are failing
Status: Active » Needs work

Lots of other functional tests are failing too -- we should probably widen the scope here, since if we tackle in separate issues we can't get a green on the MR.

joachim’s picture

joachim commented
Title: Functional tests are failing » Migration tests are failing

Oops, I stand corrected!

In which case this maybe just needs a rebase.

joachim’s picture

joachim commented
Status: Needs work » Needs review
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

I think since I just did a basic reroll, I can RTBC this.

  • fgm committed 91dc3516 on 1.x authored by bluegeek9 
    Issue #3510543 by bluegeek9: Migration test failing
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Reviewed & tested by the community » Fixed

Merged to dev HEAD, thanks to you both.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.