Problem/Motivation

If the footer is "light," the footer settings are difficult to access. Page dimension issue.

2 remaining problems:
- popover state is not synced with the backbone model state
- not possible to access the links inside the popover with the keyboard

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

laetitia_al created an issue. See original summary.

grimreaper’s picture

Assigned: Unassigned » grimreaper
grimreaper’s picture

Assigned: grimreaper » laetitia_al
Status: Active » Postponed (maintainer needs more info)
StatusFileSize
new778.77 KB

When clicking on the contextual links pen, it opens and you can scroll down.

This is a Core feature/behavior, nothing special done in Sobki.

I guess in Core, there should be a check in JS to open to the top instead of to the bottom, but would require to use an external library that handles that.

grimreaper’s picture

Or maybe in USB we can override contextual links to use https://getbootstrap.com/docs/5.3/components/popovers/ to render it. And the direction should be automatic.

laetitia_al’s picture

Assigned: laetitia_al » grimreaper
Status: Postponed (maintainer needs more info) » Active

Let's try that !

grimreaper’s picture

Title: Access to footer settings » Contextual links: use popover
Project: Sobki Bootstrap » UI Suite Bootstrap
Version: 10.1.x-dev » 5.1.x-dev
Category: Bug report » Feature request
grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Active » Needs work

Need help with contextual link JS, how better to integrate.

grimreaper’s picture

Showing screenshots.

grimreaper’s picture

Assigned: Unassigned » grimreaper
grimreaper’s picture

Assigned: grimreaper » Unassigned
Issue summary: View changes
StatusFileSize
new12.84 KB

2 remaining problems:
- popover state is not synced with the backbone model state
- not possible to access the links inside the popover with the keyboard

grimreaper’s picture

Morning thought, instead of popover, maybe change into a dropdown (which if I remember correctly can also open automatically where there is enough space).

grimreaper credited tocab.

grimreaper’s picture

Assigned: Unassigned » grimreaper

discussed with @tocab, Bootstrap popovers can't have interactive links. So focus don't go in it.

I will try to use dropdowns instead.

grimreaper’s picture

Title: Contextual links: use popover » Contextual links: use dropdown

  • grimreaper committed b743313c on 5.1.x
    Issue #3503645 by grimreaper, laetitia_al, tocab: Contextual links: use...
grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Needs work » Fixed
grimreaper’s picture

Assigned: Unassigned » grimreaper
Status: Fixed » Needs work

It breaks the contextual links in admin theme.

grimreaper’s picture

  • grimreaper committed 04a81363 on 5.1.x
    Revert "Issue #3503645 by grimreaper, laetitia_al, tocab: Contextual...
grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Needs work » Postponed

Change reverted and marking as postponed until Core issue is resolved.

grimreaper’s picture

Title: Contextual links: use dropdown » [D11.2] Contextual links: use dropdown
Version: 5.1.x-dev » 5.2.x-dev

grimreaper changed the visibility of the branch 3503645-contextual-links-use to hidden.

grimreaper’s picture

Title: [D11.2] Contextual links: use dropdown » [D11.3] Contextual links: use dropdown
Assigned: Unassigned » grimreaper

Parent issue is now merged!

To restore when Core 11.3 will be released.

And need to update Core requirement.

  • grimreaper committed eacf1e43 on 5.2.x
    feat: #3503645 Contextual links: use dropdown
    
    By: laetitia_al
    By:...
grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Postponed » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.