Problem/Motivation

tests need fixed.

Proposed resolution

Fix the tests.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tonytheferg created an issue. See original summary.

tonytheferg’s picture

phpstan

  Line   src/Form/VadoManagementForm.php                                       
 ------ ---------------------------------------------------------------------- 
  59     Method Drupal\Core\Form\ConfigFormBase::__construct() invoked with 1  
         parameter, 2 required.                                                
 ------ ---------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Plugin/Commerce/VadoGroupWidget/VadoGroupWidgetBase.php            
 ------ ----------------------------------------------------------------------- 
  465    Call to deprecated method renderPlain() of interface                   
         Drupal\Core\Render\RendererInterface:                                  
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use                
           \Drupal\Core\Render\RendererInterface::renderInIsolation() instead.  

And tests:

There were 2 failures:
1) Drupal\Tests\commerce_vado\Functional\VadoCartTest::testSyncQuantityOn
Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "edit-settings-container-hide-parent-zero-price" not found.
/builds/project/commerce_vado/vendor/behat/mink/src/WebAssert.php:731
/builds/project/commerce_vado/vendor/behat/mink/src/WebAssert.php:841
/builds/project/commerce_vado/tests/src/Functional/VadoCartTest.php:398
2) Drupal\Tests\commerce_vado\Functional\VadoManagementFormTest::testVadoManagementForm
Behat\Mink\Exception\ResponseTextException: The text "Add on product variation types" was not found anywhere in the text of the current page.
/builds/project/commerce_vado/vendor/behat/mink/src/WebAssert.php:907
/builds/project/commerce_vado/vendor/behat/mink/src/WebAssert.php:293
/builds/project/commerce_vado/web/core/tests/Drupal/Tests/WebAssert.php:979
/builds/project/commerce_vado/tests/src/Functional/VadoManagementFormTest.php:49
--
3 tests triggered 2 PHP warnings:
1) /builds/project/commerce_vado/web/core/modules/user/tests/src/Traits/UserCreationTrait.php:172
Array to string conversion
Triggered by:
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroup
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:180
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupDuplicate
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:236
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupItemGroup
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:206
2) /builds/project/commerce_vado/web/core/modules/user/tests/src/Traits/UserCreationTrait.php:188
Array to string conversion
Triggered by:
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroup
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:180
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupDuplicate
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:236
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupItemGroup
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:206
FAILURES!
Tests: 14, Assertions: 562, Failures: 2, Warnings: 2.

tonytheferg’s picture

That took care of phpstan and test failures, just have this left:

3 tests triggered 2 PHP warnings:
1) /builds/project/commerce_vado/web/core/modules/user/tests/src/Traits/UserCreationTrait.php:172
Array to string conversion
Triggered by:
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroup
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:180
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupDuplicate
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:236
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupItemGroup
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:206
2) /builds/project/commerce_vado/web/core/modules/user/tests/src/Traits/UserCreationTrait.php:188
Array to string conversion
Triggered by:
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroup
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:180
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupDuplicate
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:236
* Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupItemGroup
  /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:206
OK, but there were issues!
Tests: 14, Assertions: 611, Warnings: 2.

tonytheferg’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.