Problem/Motivation

In Drupal >= 10.4.x a refactoring of the Claro dialogue stylesheet has been performed. Issue https://www.drupal.org/project/drupal/issues/3303546

One of these changes affects the close dialogue button, which does not display the X correctly.

The change is as follows:

- Drupal 10.3.x -> .ui-dialog .ui-dialog-titlebar-close {.....
- Drupal 10.4.x -> .ui-dialog .ui-dialog-titlebar .ui-dialog-titlebar-close {.....

It is suggested to change .ui-dialog .ui-dialog-titlebar-close:empty {.... to .ui-dialog .ui-dialog-titlebar .ui-dialog-titlebar-close:empty {....

Making this change correctly displays the close button

CommentFileSizeAuthor
#4 close after.png62.62 KBbryan toapanta
close.png14.32 KBbryan toapanta

Issue fork vlsuite-3501461

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bryan toapanta created an issue. See original summary.

bryan toapanta opened merge request !59

bryan toapanta’s picture

bryan toapanta commented
Status: Active » Needs review
bryan toapanta’s picture

bryan toapanta commented
StatusFileSize
new close after.png62.62 KB

After applying the changes the button is displayed correctly.

alejandro cabarcos made their first commit to this issue’s fork.

alejandro cabarcos’s picture

alejandro cabarcos commented

@Bryan I think is a good idea to keep both selectors for compatibility. I've updated the merge request

alejandro cabarcos’s picture

alejandro cabarcos commented
crzdev’s picture

crzdev commented
Status: Needs review » Reviewed & tested by the community

Great, thanks! Integrated!

crzdev’s picture

crzdev commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.