Performance tests for navigation began failing here: #3490841: Create hook_runtime_requirements() and hook_runtime_requirements_alter() after a rebase.
That issue does not change stylesheets or how they are built.
It was last changed here #3425081: Integrate Navigation with Workspaces but that is passing and so is HEAD so I'm not sure that is the cause.
add 200 bytes headroom to the Performance test.
$this->assertLessThan(90000, $performance_data->getStylesheetBytes());
Is this the right approach?
How much headroom do we want?
N/A
N/A
N/A
N/A
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !10922
Comments
Comment #2
nicxvan commentedCredit
Comment #4
nicxvan commentedComment #5
nicxvan commentedComment #6
catchQuick fix is fine but also we should use #3477191: Add PerformanceTestTrait::assertMetrics() so it is easier to write performance tests in this test - it was the one performance test that didn't get converted in that issue.
Comment #7
dwwThanks for that pointer, @catch. Let’s see what we can do to make this stable again.
Comment #8
dwwPer Slack, catch is okay to commit this now and do the conversion in a follow up. I or nicxvan will open that follow-up momentarily, but catch only has 29 minutes to connnit this m, so here’s a quick RTBC. There’s a pipeline in the linked issue that shows this change allows that to pass. This is a trivial change. Ready!
Thanks,
-Derek
Comment #11
catchCommitted/pushed to 11.x and cherry-picked to 11.1.x, thanks!
Comment #13
dwwThanks!
Needs followup#3500360: Use PerformanceTestTrait::assertMetrics() in the navigation performance test