Problem/Motivation

WSE Config decorates both config.storage and config.storage.active in such a way that config is no longer cached. That means sites that have moved the config cache to redis or memcache no longer benefit. Sites using database caching are unaffected because cache_config and config are the same.

Steps to reproduce

Install wse_config

Proposed resolution

Consider the approach and potentially make wse_config using the ability of config overriders to affect the cache key used in cache config. This might result in a simpler approach to caching as a whole.

Remaining tasks

TBD

User interface changes

N/a

API changes

TBD

Data model changes

TBD

Issue fork wse-3497713

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

amateescu’s picture

amateescu commented
Version: 2.0.x-dev » 3.0.x-dev

amateescu opened merge request !129

amateescu’s picture

amateescu commented
Status: Active » Needs review

Worked a bit on this. Not super happy with the code still, but config cache is being used properly with the current MR.

amateescu’s picture

amateescu commented
Parent issue: » #3497636: [META] WSE Config: Path to Stable

  • amateescu committed 21b576c8 on 3.0.x 
    fix: #3497713 Enabling wse_config results in cache_config not being used...
amateescu’s picture

amateescu commented
Status: Needs review » Fixed

Even though not perfect, this is definitely an improvement, so merged into 3.0.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.