Update all JavaScript dependencies which cause no changes

The cspell issue was committed so this needs some work.

Applied locally for about 20 minutes while doing other stuff and nothing seemed off. Wasn't sure how else to test.

LGTM

Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!

Should do the equivalent update for 10.5.x/10.4.x so moving there for 'backport'

commit-code-check.sh wasn't happy, yarn check -s gave me this:

warning "backbone#underscore@>=1.8.3" could be deduped from "1.13.7" to "underscore@1.13.7"
warning Resolution field "ejs@3.1.10" is incompatible with requested version "nightwatch#ejs@3.1.8"
warning Resolution field "nightwatch#semver@7.5.4" is incompatible with requested version "nightwatch#semver@7.3.5"
warning "stylelint#debug@^4.3.7" could be deduped from "4.4.0" to "debug@4.4.0"
warning "eslint#@humanwhocodes/config-array#debug@^4.3.1" could be deduped from "4.4.0" to "debug@4.4.0"
error "espree#acorn" not installed
error "espree#acorn-jsx" not installed
error Found 3 errors.

Not sure if it's something up with my local or a problem with the MR.

There is an open issue about dedupe, https://github.com/yarnpkg/yarn/issues/7568. Someone solved that by deleting the lock file and then 'yarn install'.

Locally, that worked for the dedupe errors. Still to do is the resolution one.

automation issue is at #3280275: Set up a formal process for ensuring JavaScript dependencies remain up to date

So in 11.x and yarn 2 we don't check dependencies because the command doesn't exists. From the docs:

NOTE: The command yarn check has been historically buggy and undermaintained and, as such, has been deprecated and will be removed in Yarn 2.0. You should use yarn install --check-files instead.

The --check-files option doesn't exist anymore.

the deduping doesn't impact our vendored deps so I'd be inclined to just ignore it and remove the check. i'll try to fix it later today but might just remove that

And what about the two 'resolution' warning?

warning Resolution field "ejs@3.1.10" is incompatible with requested version "nightwatch#ejs@3.1.8"
warning Resolution field "nightwatch#semver@7.5.4" is incompatible with requested version "nightwatch#semver@7.3.5"

I think we can ignore the warnings, they might be pre-existing. Should open a follow up to try to clean this up though.

FWIW I got the Nightwatch warning in #25 on HEAD when I was prepping for the live commit at Singapore. (I.e., I believe it also happens on 11.x.) Asked @larowlan about it and he suggested ignoring that at the time.

Tagging for the Nightwatch warning followup and adding it to the IS.

I think the warnings are safe to ignore.

I fixed the errors by removing the two sets of acorn data from yarn.lock and rerunning yarn install which has deduplicated them correctly and yarn check now has warnings but no errors:

$ yarn check -s
warning "backbone#underscore@>=1.8.3" could be deduped from "1.13.7" to "underscore@1.13.7"
warning Resolution field "ejs@3.1.10" is incompatible with requested version "nightwatch#ejs@3.1.8"
warning Resolution field "nightwatch#semver@7.5.4" is incompatible with requested version "nightwatch#semver@7.3.5"
warning "stylelint#debug@^4.3.7" could be deduped from "4.4.0" to "debug@4.4.0"
warning "eslint#@humanwhocodes/config-array#debug@^4.3.1" could be deduped from "4.4.0" to "debug@4.4.0"

I can further fix the debug and underscore warnings by removing those from the lockfile and running yarn install again. This just leaves:

$ yarn check -s
warning Resolution field "ejs@3.1.10" is incompatible with requested version "nightwatch#ejs@3.1.8"
warning Resolution field "nightwatch#semver@7.5.4" is incompatible with requested version "nightwatch#semver@7.3.5"

I think these are consequences of pinning to Nightwatch 2.4.2, we have been unable to upgrade further in Drupal 10 (but have moved to Nightwatch 3 in Drupal 11).

That makes sense with the Nightwatch mis-match, good to narrow everything down. Let's get this in.

we upgrading node packages to major versions without reading changelog ;)
https://github.com/paulmillr/chokidar?tab=readme-ov-file#upgrading

it is broken now core/scripts/css/postcss-watch.js

const fileMatch = './**/*.pcss.css';
// Ignore everything in node_modules
const watcher = chokidar.watch(fileMatch, {
  ignoreInitial: true,
  ignored: './node_modules/**'
});

so for 1.5 month `yarn watch` not working ;)

Follow up issue
https://www.drupal.org/project/drupal/issues/3504265

Amending credit.