Before fixing the issue:

before

CommentFileSizeAuthor
#9 after_compiled_css.png20.88 KBjaydeep_patel
#3 after-.png39.24 KBalok_singh
before.png58.18 KBalok_singh

Issue fork rigel-3491834

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alok_singh created an issue. See original summary.

alok_singh opened merge request !88

alok_singh’s picture

alok_singh commented
Assigned: alok_singh » Unassigned
Status: Active » Needs review
StatusFileSize
new after-.png39.24 KB

After fixing the issue. Please compile scss before review.

after

jaydeep_patel’s picture

jaydeep_patel commented
Status: Needs review » Needs work

@alok_singh, Please compile scss to css and then push your code. Changes not reflected hance moving back to NW.

Thank you

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Anonymous’s picture

Anonymous (not verified) commented
Assigned: » Unassigned
dhruv.mittal’s picture

dhruv.mittal commented
Assigned: Unassigned » dhruv.mittal

Working on it

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: dhruv.mittal » Unassigned
Status: Needs work » Needs review

@jaydeep_patel I have compiled the scss to css now, Please have a look.

jaydeep_patel’s picture

jaydeep_patel commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after_compiled_css.png20.88 KB

Thanks for fixing the issue @dhruv.mittal,

I have reviewed this issue MR!88 applied successfully and it's looks good to me. I have attached screenshot for the reference and moving it to RTBC.

Thank you

baldwinlouie’s picture

baldwinlouie commented
Status: Reviewed & tested by the community » Needs work

@dhruv.mittal and @jaydeep_patel , Thank you for the merge request. Can you please double check the compiling of the SCSS? The changes in _component.css is fairly minimal, but main.css has a lot of changes to it.

dhruv.mittal opened merge request !92

dhruv.mittal’s picture

dhruv.mittal commented
Status: Needs work » Needs review

I have removed unnecessary changes please review now.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@dhruv.mittal, Thank you for updating the patch. It looks good to me now. Marking RTBC.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: On mobile view, Searched page - Search button needs space. » Fix the space for the search button on the searched page in mobile view
Issue summary: View changes

@dhruv.mittal

Thank you for the update.

@baldwinlouie

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

yas changed the visibility of the branch rigel-3491834 to hidden.

  • yas committed 60f2c722 on 8.x authored by dhruv.mittal 
    Issue #3491834 by dhruv.mittal, alok_singh, jaydeep_patel, akulsaxena,...

  • yas committed c673e1eb on 7.x 
    Issue #3491834 by dhruv.mittal, alok_singh, jaydeep_patel, akulsaxena,...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.