Problem/Motivation

https://github.com/ckeditor/ckeditor5/releases/tag/v44.0.0

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3491464

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This has a new requirement for a license key. We can default it to "GPL" but https://www.drupal.org/project/ckeditor5_premium_features also wants to set this so we should ensure that is still possible.

longwave opened merge request !10448

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented

Code changes seem fine an GitLab loves them.

This has a new requirement for a license key. We can default it to "GPL" but https://www.drupal.org/project/ckeditor5_premium_features also wants to set this so we should ensure that is still possible.

Not too sure if we're supposed to this this here or in the contrib queue for ckeditor5_premium_features ?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

We need to set GPL here or CKEditor5 fails to initialize with "license-key-missing": https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#erro...

The code is designed to allow any plugin to set licenseKey and only set it as a last resort, I haven't manually tested with the Premium Features module though.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

@longwave, Ah, I seee, thanks for explaining.

We _could_ open an issue in their queue and wait for confirmation, we could test it ourselves or we could just steamroll ahead.

First option is probably going to taken longer than the window we have before 11.1.0 gets shipped, option #2 is for the nice people out there.
Sadly I'm not one of those, going to mark this RTBC to get this in 11(.1).x ASAP (10.4/5 seem to have a broken HEAD) and move one.

The ~12.000 install aren't going to jump to 11.1.0 immediately, so if things go wrong with the key, there's time to fix it.

salmonek’s picture

salmonek commented

Hi, I already tested the update with Premium Features and Plugin Pack's Templates.
Recent versions of both modules are working fine with this update.

spokje’s picture

spokje
Primary language Dutch
commented

Thanks @salmonek, for both being a nice person and reporting back :)

  • catch committed d5e5feb5 on 11.x 
    Issue #3491464 by longwave, spokje, salmonek: Update CKEditor 5 to 44.0....

  • catch committed ee4378d7 on 11.1.x 
    Issue #3491464 by longwave, spokje, salmonek: Update CKEditor 5 to 44.0....
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!

Moving to 10.4.x for backport.

catch closed merge request !10448

longwave opened merge request !10460

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Patch (to be ported) » Needs review

MR!10460 should apply to both 10.4.x and 10.5.x.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems a number of failures on 10.5.x

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

@smustgrave Are you sure? I see a fully green pipeline on this MR: https://git.drupalcode.org/project/drupal/-/pipelines/359531

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Weird definitely when I opened it almost all functional tests were failing + nightwatch but yea it's green again.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Some tests are being super flaky at the moment, not sure why.

longwave closed merge request !10460

  • longwave committed a026efe5 on 10.4.x 
    Issue #3491464 by longwave, spokje, salmonek, catch: Update CKEditor 5...

  • longwave committed 8bdb090a on 10.5.x 
    Issue #3491464 by longwave, spokje, salmonek, catch: Update CKEditor 5...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +11.1.0 release notes, +10.4.0 release notes

Committed and pushed 8bdb090a3db to 10.5.x and a026efe5199 to 10.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.