Problem/Motivation

We lowered MINIMUM_STABILITY to 'RC' in core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php to accommodate php-tuf/composer-stager which currently on has RC releases.

Steps to reproduce

Proposed resolution

As soon as php-tuf/composer-stager has an official release, bump MINIMUM_STABILITY back to 'stable'.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3490698

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

spokje created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented

Also opened #3490709: Try to move php-tuf/composer-stager to a dev dependency until package_manager is stable in case that's an option (didn't try yet).

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !10574

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Needs work

MINIMUM_STABILITY should be set to 'stable' in core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php.

Not to sure we want to change the composer.json files.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Thanks I knew I was doing something wrong but couldn't remember what the right thing was.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Two test-failures, one is a known random, the image one I haven't seen before myself, but I would find it _very_ weird if that could be cause by tuf.

Marking as RTBC.

  • alexpott committed 63be3c48 on 11.1.x 
    Issue #3490698 by catch, spokje: Bump MINIMUM_STABILITY back to 'stable...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed c9c3966566e to 11.x and 63be3c483d3 to 11.1.x. Thanks!

  • alexpott committed c9c39665 on 11.x 
    Issue #3490698 by catch, spokje: Bump MINIMUM_STABILITY back to 'stable...
luenemann’s picture

luenemann
Primary language German
Location Südbaden, Germany
commented
Status: Reviewed & tested by the community » Fixed
luenemann’s picture

luenemann
Primary language German
Location Südbaden, Germany
commented
Status: Fixed » Reviewed & tested by the community

Back to RTBC. No credit assigned.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.