In header component, service_title is a slot, but it is used in a HTML attributes:

              <a href="{{ home_url|default('/') }}" title="{{ 'Homepage'|t }} - {{ service_title }} - {{ logo_text }}">
                <p class="fr-header__service-title">{{ service_title }}</p>
              </a>

This is not possible for 2 reasons;

  • not the expected data type/structure
  • breaks the visual display builders (like layout builder)

What do we do?

CommentFileSizeAuthor
#2 Header-service_title-is-not-a-slot-3490540.patch1015 bytesniharika.s

Issue fork ui_suite_dsfr-3490540

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

niharika.s’s picture

niharika.s commented
Assigned: Unassigned » niharika.s
Status: Active » Needs review
StatusFileSize
new Header-service_title-is-not-a-slot-3490540.patch1015 bytes

I have applied the changes in pattern-header.html.twig please review and let me know if any other changes required.

pdureau’s picture

pdureau commented
Assigned: niharika.s » Unassigned
Status: Needs review » Needs work

niharika patch is not OK because:

  • a patch, not a PR
  • no change in the definition file
  • change in template is weird
  • no linting
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: Unassigned » just_like_good_vibes

i will take it

just_like_good_vibes opened merge request !140

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.