Closed (fixed)
Project:
Group
Version:
3.3.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
21 Nov 2024 at 13:45 UTC
Updated:
19 Dec 2024 at 11:34 UTC
Jump to comment: Most recent
As reported by @scotwith1t, the upgrade seems to go wrong because there are no upgrades once you switch to v3. This is because I cherry-picked an update hook from v3 to v2 without changing the number. Silly me.
Let's fix this ASAP.
Comments
Comment #3
kristiaanvandeneyndeComment #6
kristiaanvandeneyndeWill cut a release and recommend people affected by this bug run:
Comment #7
yazzbe commentedIn shell (bash) I had to include parentheses.
Comment #8
kristiaanvandeneyndeUpdated the release notes
Comment #9
aurora.luzzardiAre you sure that this only happens from 2.3 to 3.3?
I have this message when upgrading from 3.2.2 to 3.3.1:
And then the upgrades runs:
Those should be running even coming from 3.2 installations?
Comment #10
kristiaanvandeneyndeDammit you're right I shouldn't have upped that number in 3.3.x.
Will hotfix release in the morning. This mess is coming from the fact that we have two versions being kept in sync but with different update hook numbers :/
The update hooks to go from 2 to 3 don't do anything if you're already on 3.
Comment #11
scotwith1tI suppose the good news is that the update hooks, if a user resets the schema version via drush and runs them a second time, should probably not find anything to update anyway. 🤷♂️ Thanks for your work on this as always Kristiaan.
Comment #12
nickdjmTrying the update out after I reset the installed version to 9211 and I get the following error:
The only place I see reference to 'group_content' is in my config. All custom and contrib code has been updated appropriately. Should I be updating the config before I try to run the updates? Or should the updates be taking care of that?
Comment #13
tyler.hastainIt appears that comment #7 solved the problem for us.
Comment #15
kristiaanvandeneyndehttps://www.drupal.org/project/group/releases/3.3.2
Also re #12, it seems like some search_api code is running before Group has had a chance to fully convert group_content to group_relationship.
Comment #16
kekkisThe
group_update_9211function is now defined twice ingroup.installin version 2.3.1. I'll create a follow-up.Comment #17
kekkisAdded the issue I encountered as a related issue although I recognized it's not actually an issue with this change, rather with another MR sharing the hook ID.
Comment #18
nickdjmRe #15 ah yeah, only way we're finding around it is disabling search_api entirely, otherwise it just fails. I'll see if I can find a solution that does not involve uninstalling the module and if it's something group-related I'll open an issue/MR.
Comment #19
aurora.luzzardi#10 I did not see the error anymore about the installed version being too old.
But I still see the database updates running after the upgrade from 3.2.2 to 3.3.2
Is that the expected behavior if I'm not upgrading from version 2.x?
My feeling is that upgrades, if needed to run, should check an show a notice/information that they are not running as the current version is already version 3.x
Comment #20
kristiaanvandeneyndeHooks group_update_10300 through group_update_10302 run but don't do anything if you were already on v3. Hook group_update_10303 needs to run no matter what version you came from.
Comment #21
aurora.luzzardikristiaanvandeneynde Thanks for explaining!