Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Update all stylelint-related JavaScript dependencies to their latest releases.
Priority Critical, since it parent was deemed Critical
Steps to reproduce
$ yarn upgrade-interactive
Proposed resolution
? Pick the packages you want to upgrade. Current Range Latest
stylelint-config-standard ------------------- ◯ ^34.0.0 ------ ◉ ^36.0.1
stylelint-prettier -------------------------- ◯ ^4.1.0 ------- ◉ ^5.0.2
stylelint ----------------------------------- ◯ ^15.11.0 ----- ◉ ^16.10.0
Remaining tasks
Backport this to the gazillion current branches, TBD by the core committers.
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3488005
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3488005-10.5.x
changes, plain diff MR !10450 - 3488005-10.5.x-stylelint-bump changes, plain diff MR !10449
- 3488005-10.5.x-bump-stylelint changes, plain diff MR !10339
- 11.x compare
- 3488005-11.x-bump-stylelint changes, plain diff MR !10338
- 3488005-update-styleint-to changes, plain diff MR !10215
Comments
Comment #2
spokjeComment #3
spokjeComment #4
spokjeComment #5
spokjeComment #7
spokjePostponed on the landing of #3467309: Replace abandoned, not working with latest stylelint, leon0399/stylelint-formatter-gitlab with gitlab-formatters/stylelint-formatter-gitlab since
leon0399/stylelint-formatter-gitlabdoes not work withstylelintversions above 15.x.Comment #8
spokjeComment #9
longwaveThe formatter change has landed so finally we can action this.
Comment #15
spokjeComment #16
longwaveAfter applying this MR, running
yarn lint:csslocally seems to hang forever now, not sure why.Comment #17
spokje@longwave Can't reproduce that locally.
Also https://git.drupalcode.org/issue/drupal-3488005/-/jobs/3485149#L272 indicates that the same command, but with added frills like caching and custom formatters does, at the very returns and doesn't get stuck.
Comment #18
longwaveYeah it's probably something specific to my local environment, will have to figure out what. I tried deleting
node_modulesand reinstalling but that made no difference.Comment #19
smustgrave commentedNot super fast and since there is no progress indicator I thought maybe it got hung up on my local ddev too but it did complete after about a minute.
Comment #20
catchOn my local this is fine.
Would be good to get another try from @longwave since this runs on commit, so we don't want a situation where we commit this, then @longwave can't commit any patches until the problem is fixed.
Comment #23
longwaveIt must be something to do with my core development playground directory, because it only hangs there.
I have a separate clean checkout for committing, and there I get a similar result to @catch:
Committed and pushed 7f47553bf9c to 11.x and 05391a62745 to 11.1.x. Thanks!
Marking PTBP to pull this back to 10.5.x/10.4.x.
Comment #30
spokjeWhat have we learned:
1. Updating an MR on non-11.x in a branch made from 11.x many moons ago is a nightmare
2. Not-so-random-failures in 10.5.x tests that don't seem related to the changes in this MR. Dropped a few lines in Slack about this.
Comment #31
spokjeRight some rollbacks later, and we have a green MR.
Comment #34
longwaveLanding this one from NR as 10.4.0 is this week and it seems the most practical thing to do to keep this in sync with 11.1.0.
Committed 6b00903 and pushed to 10.5.x. Thanks!
Committed 6995c90 and pushed to 10.4.x. Thanks!