Problem/Motivation

Stale rejections block transition.

Steps to reproduce

  1. Create a workspace
  2. Add content to workspace
  3. Submit the workspace to 2 reviewers
  4. Have reviewer 1 reject the content
  5. Have reviewer 2 approve the content
  6. Submit the content again to the same reviewers (simulating a submission after changes were made to address the rejection)
  7. Have both reviewer 1 and reviewer 2 approve the content
  8. Navigate to Workspace Workflow and the transition state is still Draft and "Submit for Legal Review" is NOT available to change the state
  9. Navigate to Workspace Approvals and Approve the original Rejection
  10. The workspace now changes state and Submit For Legal Review

Proposed resolution

Unpublish the stale review requests. This keeps them for audit purposes, but the are no longer publically viewable.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork workspace_approval-3487813

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

heddn created an issue. See original summary.

heddn opened merge request !17

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Looking at the code, the original intent was to always re-use a review. This is a bug that can easily be fixed.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review

  • heddn committed 5990a66a on 1.0.x 
    Issue #3487813 by heddn, marvil07: Stale rejections block transition

heddn credited marvil07.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Fixed

I've opened #3488650: Add option on the approval type to decide if the set of approvals needs to be an AND or an OR for a follow-up.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.