Overview

Implement the "Page" content entity type as defined in #3482259: Landing page integration: new content entity type for unstructured content

Proposed resolution

This is a scaffolding issue:

  • creating the entity class
  • title, description, component_tree base fields
  • view builder handler

User interface changes

Issue fork experience_builder-3487071

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Component: Data model » Page
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: Unassigned » mglaman

mglaman opened merge request !405

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: mglaman » Unassigned
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

Definitely on the right track! 🤩

Initial review round on MR 😊

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review

The initial review was addressed

wim leers credited tedbow.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I should not be a blocking factor in signing off on this.

Let's land this if/when @tedbow and @longwave approve this.

lauriii made their first commit to this issue’s fork.

  • lauriii committed 286e1408 on 0.x authored by mglaman 
    Issue #3487071 by mglaman, wim leers, tedbow: Create Page entity type
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Fixed

Merged this based on @tedbow approval. I had to bypass the approvals because there wasn't approval from /src/Entity code owner. We got review from @wim leers and this is adding a new entity type so it seems fine to bypass the approval there.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.