Problem/Motivation
Piwik PRO is deprecating the old sync tags in favor of the async tags. This will happen in January 2025. More information about this change is available in https://help.piwik.pro/support/tag-manager/sunset-of-synchronous-contain....
At the moment there is a setting in the module that allows the administrator to enable the sync tag containers.
There is on going work to move the script code from PHP files to external JS files in task #3482342: Move JS snippets to separate script files. This change is not soon needed anymore so those files do not need updating at the moment.
Steps to reproduce
-
Proposed resolution
Because the sync tags are deprecated the script is not going to work later. We should remove the current module setting and remove the sync script from the code.
Remaining tasks
1. Remove module setting Additional container (sync).
2. Remove code from the module that the setting controls.
3. Update tests to reflect the change.
User interface changes
1. Admin setting for the sync tag container is removed.
API changes
1. No scripts are embedded for sync tags.
Data model changes
1. Config schema needs to be updated and the old configurations cleaned out.
| Comment | File | Size | Author |
|---|---|---|---|
| Screenshot 2024-11-11 at 12.34.32.png | 14.42 KB | heikkiy |
Issue fork piwik_pro-3486733
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
heikkiy commentedExternal links module has a good example where there is a notice for users already using this setting which is shown during install process: https://git.drupalcode.org/project/extlink/-/merge_requests/42/diffs#a2b...
We should implement a similar notice when we deprecate the current setting.
As the first step we could disable the setting from everyone and disable the setting with that notice. And after that we can remove the setting completely.
Comment #3
dimas11 commentedComment #5
hartsak commentedThanks @dimas11!
I tested the changes and everything seems to work fine. No complaints from me.
Comment #7
heikkiy commentedComment #8
heikkiy commentedThis was reviewed and fixed at the same time.