Problem/Motivation

%Since twig/twig 3.12: Twig Filter "spaceless" is deprecated%

Steps to reproduce

Proposed resolution

We can remove it without any problems and get better perfomance
https://github.com/twigphp/Twig/pull/4236
https://github.com/twigphp/Twig/pull/4308

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3486170

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

godotislate created an issue. See original summary.

godotislate opened merge request !10087

godotislate’s picture

godotislate
he/him
commented
Status: Active » Needs review
Issue tags: -Needs issue summary update

Copied commits from MR 9665 from #3477375: Provide non-deprecated replacement for Twig "spaceless" filter to MR here, so hopefully the appropriate credits will be captured.

smustgrave’s picture

smustgrave commented

Left 1 comment on MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Applied the MR and searched for {% apply spaceless %} and all instances appear to be replaced.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3488365: Upgrade twig/twig to 3.15.0

nod_ credited bbrala.

nod_ credited finnsky.

nod_ credited longwave.

nod_’s picture

nod_
Primary language French
Location Lille
commented

Porting credit

  • nod_ committed c4a2659d on 11.1.x 
    Issue #3486170 by godotislate, bbrala, finnsky, longwave: Remove use of...

  • nod_ committed 69dc12e1 on 11.x 
    Issue #3486170 by godotislate, bbrala, finnsky, longwave: Remove use of...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.5.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed c4a2659 and pushed to 11.1.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@nod Why do we need to port this to Drupal 10.5.x?

nod_’s picture

nod_
Primary language French
Location Lille
commented

I thought we wanted to upgrade twig in 10.5.x, if that's not the case, no need for this backport

godotislate closed merge request !10087

godotislate’s picture

godotislate
he/him
commented

Is this being ported to 10.5.x? Just noticed it's been in "Patch (to be ported)" for a couple months now.

smustgrave’s picture

smustgrave commented
Status: Patch (to be ported) » Reviewed & tested by the community

Should this backported?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 10.5.x-dev » 11.1.x-dev
Status: Reviewed & tested by the community » Fixed

Discussed with @longwave and @catch given we're never going to upgrade 10.5.x to Twig 4 we don't need to do this one.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.