Problem/Motivation

Running the new test gitlab-ci tests phpcs is allowed to pass, but it should be fixed:
https://git.drupalcode.org/project/pasc/-/jobs/3237529

Steps to reproduce

Run phpcs

Proposed resolution

Review the phpcs test results to evaluate the issues and fix them.

Remaining tasks

Fix the code to allow the tests to pass.
Commit the code
Re-run phpcs

Issue fork pasc-3485343

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

the_g_bomb created an issue. See original summary.

arunsahijpal’s picture

arunsahijpal commented
Assigned: Unassigned » arunsahijpal

the_g_bomb opened merge request !3

the_g_bomb’s picture

the_g_bomb commented
Status: Active » Needs review
arunsahijpal’s picture

arunsahijpal commented
Assigned: arunsahijpal » Unassigned
a.aaronjake’s picture

a.aaronjake commented
Status: Needs review » Reviewed & tested by the community

Hi @the_g_bomb,

I have checked the pipeline and confirmed the phpcs job succeeded: 3248720

Will now move this to RTBC

Thanks,
Jake

the_g_bomb’s picture

the_g_bomb commented
Status: Reviewed & tested by the community » Fixed

Thank you for the review, merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.