Problem/Motivation

Visiting the Watchdog mailer settings page after updating from ^2 to ^3, I get the following Warning:
Warning: foreach() argument must be of type array|object, null given in Drupal\watchdog_mailer\Form\SettingsForm->buildForm() (Zeile 247 in /web/modules/contrib/watchdog_mailer/src/Form/SettingsForm.php).

Once this is fixed, we should publish 3.0.0-rc2 and make it the suggested version!

Steps to reproduce

Install watchdog mailer ^2
Update to watchdog mailer ^3
Run updates
Visit the settings page and see the warning

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork watchdog_mailer-3484810

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Looks like the update path has a bug or is incomplete. @lrwebks can you fix this?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

$notificationObjects = $config->get('notification_objects');
should return an empty array but returns null, because it's not set as array in the update hook.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review

anybody opened merge request !34

lrwebks’s picture

lrwebks commented
Assigned: Unassigned » lrwebks
Status: Needs review » Needs work
lrwebks’s picture

lrwebks commented
Assigned: lrwebks » Unassigned
Status: Needs work » Active
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

What's left to be done? Isn't this fine already?

lrwebks’s picture

lrwebks commented
Status: Active » Reviewed & tested by the community

Patch works, RTBC!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review!

  • anybody committed 27dabfde on 3.x 
    Issue #3484810 by anybody, lrwebks: Warning after Update from ^2 to ^3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.