Problem/Motivation

upgrade_status reports:

web/modules/contrib/nodeaccess/nodeaccess.install 111 Call to deprecated function user_roles(). Deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use Drupal\user\Entity\Role::loadMultiple() and, if necessary, an inline implementation instead.
web/modules/contrib/nodeaccess/nodeaccess.info.yml 6 Value of core_version_requirement: ^8 || ^9 || ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

CommentFileSizeAuthor
#8 nodeaccess1.png49.8 KBsarigaraghunath
#8 nodeaccess.png26.91 KBsarigaraghunath
#8 nodeaccess_module.png27.16 KBsarigaraghunath

Issue fork nodeaccess-3484676

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings’s picture

benstallings commented
Issue summary: View changes

benstallings opened merge request !16

benstallings’s picture

benstallings commented
Status: Active » Needs review
benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned

jradhak made their first commit to this issue’s fork.

jradhak changed the visibility of the branch 3484676-d11_ready to hidden.

sarigaraghunath’s picture

sarigaraghunath commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new nodeaccess_module.png27.16 KB
new nodeaccess.png26.91 KB
new nodeaccess1.png49.8 KB

MR16 works fine in both d10 and d11. MR16 makes the module compatible with d11. Please find the screenshots attached.

d.fisher’s picture

d.fisher commented

This is really good progress! Thank you so much for your effort on this. Any word on getting this merged?

alison’s picture

alison
she/her
commented

Hi and thank you for the work! I'm very sorry but I don't have an ETA on merging, I took a look at the code but I need to look at it more carefully, unless another co-maintainer can get to it before I do.

I'm sorry I don't have a better update, I just didn't want to leave y'all with complete radio silence.

d.fisher’s picture

d.fisher commented
Priority: Normal » Critical

Got all tests to pass. This is the last module we're waiting on to get one of our projects migrated to Drupal 11. Any ETA on review and merge?

d.fisher’s picture

d.fisher commented

Bump.

doxigo made their first commit to this issue’s fork.

doxigo’s picture

doxigo commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot Darren, merged.

d.fisher’s picture

d.fisher commented

Amazing. Thank you! Really appreciate it. Is there an ETA for a tagged release?

doxigo’s picture

doxigo commented

Nothing on my end, not actively working on nodeaccess at all, but I'd say let's give it a bit and see how things are and if all is good we can tag a new release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.