Hi,

Thank you for this module.

When I upgraded to 2.0.1 I am getting this error when I run drush:

PHP Fatal error: Type of Drupal\advanced_email_validation\Form\SettingsForm::$typedConfigManager must not be defined (as in class Drupal\Core\Form\ConfigFormBase) in /var/www/html/mysite/web/modules/contrib/advanced_email_validation/src/Form/SettingsForm.php on line 16

The error goes away if I downgrade to 2.0.0.

Drupal 10.3.6
PHP 8.3.6
MySQL 10.11.8

Issue fork advanced_email_validation-3481910

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

duckydan created an issue. See original summary.

pearls’s picture

pearls commented

I have the same problem.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Priority: Normal » Critical

I'm asking about possible approaches in https://drupal.slack.com/archives/C1BMUQ9U6/p1729460598212899

If you don't have access to that you can get it at https://drupal.org/slack

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Version: 2.0.1 » 2.x-dev
Assigned: Unassigned » darvanen
Status: Active » Needs work

I've been advised to use this method: https://previousnext.com.au/blog/safely-extending-drupal-10-plugin-class...

Working on it now.

darvanen opened merge request !29

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs work » Needs review

Let's see if that passes

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Assigned: darvanen » Unassigned
Status: Needs review » Reviewed & tested by the community

Considering the criticality of this issue I'm going to commit and release this before 2.0.1 breaks more upgrades

  • darvanen committed 9c16f39a on 2.x 
    Issue #3481910 by darvanen, duckydan: Drush error
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Fixed

Forgot to mention: all tests green.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

This has now been released, thank you for the quick report!

darvanen credited mstrelan.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.