Problem/Motivation
I've been updating modules on a Drupal 10.2 site with Inline Responsive Images and have found that the new 3.0.0 is incompatible with Drupal 10.2 because the class Drupal\filter\Attribute\Filter isn't present until 10.3. The site emits an error on database update:
The "filter_imagestyle" plugin does not exist. Valid plugin IDs for Drupal\filter\FilterPluginManager are: ...
Steps to reproduce
- Start with a Drupal 10.2 site with the module on a version prior to 3.0.0
- Update module to 3.0.0 without updating site to 3.0.0
Proposed resolution
Version 3.0.1 should be cut with drupal/core requirements set to 10.3 and above. This won't solve the problem for 10.2 users though. Perhaps a patch could be defined for 10.2 users rolling back the change?
Remaining tasks
Patch module and test.
User interface changes
None.
API changes
None.
Data model changes
None.
Issue fork inline_responsive_images-3480571
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
geoffreyr commentedComment #4
geoffreyr commentedMR ready. If you want to set 3.0.1 as being for 10.3 and above you won't want to merge this, but anyone else who finds this issue can use the plain diff source to download it and use it in their sites.
Comment #7
vladimirausGood point. Let's keep those changes in 4.0.x.
Comment #8
vladimirausCommitted and released. Thank you 🧁