Closed (fixed)
Project:
Experience Builder
Version:
0.x-dev
Component:
Config management
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Oct 2024 at 16:30 UTC
Updated:
5 Nov 2024 at 13:04 UTC
Jump to comment: Most recent
Comments
Comment #2
wim leersInitial commit present, much left to be done!
Comment #4
wim leersThe MR should now be green and supports the following operations for
PageTemplateconfig entities, with detailed test coverage:@todofor still needing to validate no other config entities depend on this one, see #3423459: [PP-4] JSON:API DELETE support for config entities.Next up:
POSTandPATCHsupport, which is what will involve copying parts of #2300677: JSON:API POST/PATCH support for fully validatable config entities.Comment #5
wim leersPer #4 and the green CI pipeline: ready for an initial review pass :)
(Tip: look at the diff locally, and exclude the first commit — which is literally just bringing in #3478537: Introduce an XB `PageTemplate` config entity.)
Comment #6
longwaveAs usual the approach looks good so far but the proof will be in the PATCH and POST APIs!
Comment #7
wim leers#3478537: Introduce an XB `PageTemplate` config entity landed. Merged upstream
0.xinto this MR; this MR is now much smaller 👍Comment #8
wim leersFully ready, including detailed functional tests that prove config validation is doing its job 😊
Comment #9
wim leersBTW: one part I know still needs to happen: document the response shapes in
/openapi.yml. But given my upcoming reduced availability, I think it'd be better for somebody else to take that on 😇Comment #10
wim leersComment #12
wim leersReviewed by both @tedbow (from HTTP API POV) and @f.mazeikis (from config management POV), and previously by @longwave (from core committer POV).
All feedback addressed.
Let's land this :)
Comment #14
wim leers