Problem/Motivation

As I probably found out hard in #3479958: Allow rendering the submenu items instead of current level the module seems to miss cache contexts and when caching is enabled, the block output seems to be cached forever, once built?

See

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_submenu_block-3479979

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !5

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Seems to work fine, please review!

grevil’s picture

grevil commented
Status: Needs review » Needs work

Generally LGTM! Just one tiny adjustment.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review

Fixed!

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

Nice, thanks! RTBC!

  • anybody committed 6a7312ae on 8.x-1.x 
    Issue #3479979 by anybody, grevil: Implement route cache context
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.