Problem/Motivation

hi, the Commerce Hubspot Engagement () submodule is not drupal 10 compatible, i will attach patch in the comments.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 commerce-hubspot-engagement-drupal-10-compatibility-3479480-2.patch1.29 KBdastan56

Comments

dastan56 created an issue. See original summary.

dastan56’s picture

dastan56 commented
Status: Active » Needs review
StatusFileSize
new commerce-hubspot-engagement-drupal-10-compatibility-3479480-2.patch1.29 KB

patch attached.

  • ebd4fb7a committed on 2.x 
    Issue #3479480 by dastan56: Commerce Hubspot Engagement Drupal 10...
shabana.navas’s picture

shabana.navas commented
Status: Needs review » Reviewed & tested by the community
shabana.navas’s picture

shabana.navas commented
Status: Reviewed & tested by the community » Fixed
dastan56’s picture

dastan56 commented

thanks for the quick response, please give credit for the patch, thanks

krystalcode’s picture

krystalcode commented
Status: Fixed » Active

The Engagement submodule is completely non-functional on branch 2.x and all of its integration code has been removed. It only works on branch 1.x. The module has been intentionally left as incompatible with Drupal 10. We don't want any new sites to install the submodule.

Moving forward, the submodule should actually be either removed including the entities that have been created. Or, rewrite it if somebody sponsors it, on the same lines that the base module was rewritten.

@shabana.navas @dastan56 I'm not sure if there is a better solution here. If this is to help existing projects to avoid patches or using special git branches, I'd be ok if it is marked as Drupal 10-compatible but change the module's title in the info file to "Commerce Hubspot Engagement [DO NOT INSTALL - UNSUPPORTED]".

krystalcode’s picture

krystalcode commented
Status: Active » Needs work

  • krystalcode committed beddac15 on 2.x 
    Issue #3479480 Marked engagement submodule as deprecated
krystalcode’s picture

krystalcode commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.