Problem/Motivation

DRupal status report warns vlsuite bundle fields must be uninstalled.

Steps to reproduce

Install VLsuite modules that adds bundle fields. Then go to status report. It will mention that vlsuite bundle fields needs to be uninstalled.

Proposed resolution

Drupal requires any bundle field to be added to entity field storage info hook. Otherwise, it will recognize the bundle as a field that needs to be removed.

So, implementing that hook for each bundled class that adds extra fields is key.

Issue fork vlsuite-3476173

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omarlopesino created an issue. See original summary.

omarlopesino opened merge request !50

omarlopesino’s picture

omarlopesino
he/him
commented
Assigned: omarlopesino » Unassigned
Status: Active » Needs review

Please review the attached MR, thanks!

crzdev’s picture

crzdev commented

Then core patch related to bundle fields should not be needed, pending checking this for all use cases that suite provides as remove just some of those fields or entities & verify base tables.

omarlopesino closed merge request !50

crzdev’s picture

crzdev commented
Status: Needs review » Needs work

Not working current approach into all scenarios, adjusting with @omarlopesino
Storages are installed when first block module uses specific type, as usages are multiple, that "provider" should be "vlsuite_bundle_fields" in order to adjust install / uninstall storages properly.

crzdev’s picture

crzdev commented

To evaluate after new approach is ready:
- Check existing site (without status report errors)
- Check layout builder bundle fields patch is not required any more

omarlopesino opened merge request !58

crzdev’s picture

crzdev commented
Status: Needs work » Reviewed & tested by the community

New approach working as expected:
- Layout builder bundle fields added to field map still needed
- No error report related to bundle field storages
- Tested with new vlsuite demo setup
- Tested for existing sites

  • crzdev committed 8b2460a0 on 2.x authored by omarlopesino 
    Issue #3476173 by omarlopesino, crzdev: Add bundle fields to entity...
crzdev’s picture

crzdev commented
Status: Reviewed & tested by the community » Fixed

MR changes integrated into 2.x!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.