Problem/Motivation

FILE: advanced_sanitize\advanced_sanitize.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

FILE: advanced_sanitize\config\schema\advanced_sanitize.edit.yml
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
13 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: advanced_sanitize\src\AdvancedSanitizeService.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------------------------------------------------
151 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
152 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
153 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
154 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
155 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
156 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
157 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
158 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
158 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
158 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: advanced_sanitize\src\Form\SanitizeSettingsForm.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------
43 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
44 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
45 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Run phpcs command to get the drupal coding standard issues.

Proposed resolution

Many of the issues can be fixed by running the phpcbf command. For the remaining ones, we will need to manually address and then commit these changes before pushing them.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sunil jolapara created an issue. See original summary.

sunil jolapara’s picture

Status: Needs work » Needs review

avpaderno made their first commit to this issue’s fork.

aylis’s picture

Status: Needs review » Fixed

Changes were merged to 1.0.x branch. Thanks a lot!

aylis’s picture

Status: Fixed » Closed (fixed)