Problem/Motivation
See https://github.com/scaleflex/js-cloudimage-360-view/issues/166.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork js_cloudimage_360_view-3475501
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
grevil commentedNote, that currently we won't show the "hide_360_logo" option through states, if the control checkbox is activated!
Comment #3
thomas.frobieterThis is the default behaviour of the library, so I don't think we should change it (in the Drupal module), nor should we spend time on it @Anybody?
Comment #5
anybodyThere's nothing we can / should do about it here. We should not implement any special behavior for this. Maybe one day that will be fixed in the library or not...
As this might be confusing for users (and us), we should simply link the issue in the settings description, until that's solved.
@Grevil: I read the sentence:
several times and looked into the code, but don't understand what's meant here. Could you explain it, if it's relevant or link the line of code you're talking about?
Comment #7
anybodyComment #8
thomas.frobieter@anybody State API, conditional fields. If "enable controls" is true, the "show 360 logo" option is hidden.
But... auum, @grevil this seems wrong? The 360° logo setting depends on the autoplay setting. If autoplay is true, the 360 logo will never appear. So if autoplay is true => hide the "show 360 logo" option.
And yes, without custom code there is nothing we can do here. From my point of view it is fine to set this to 'not fixed'.EDIT: Oops, wrong issue, but still.. the 360° logo depends on the autoplay setting. The controls thing is clearly a bug, so we dont need to reflect this in the field formatter settings.
Comment #10
thomas.frobieterComment #11
anybodyRoot cause must then be fixed upstream. If that will ever happen, the description link can be removed.
Comment #12
grevil commentedHuh? This issue should be a reminder, for when the issue is fixed upstream. Nothing more.
Comment #13
grevil commentedPOSTPONED on https://github.com/scaleflex/js-cloudimage-360-view/issues/166.
Comment #14
anybodyComment #15
grevil commentedThis seems to be fixed for 4.0! So now this is postponed on #3569161: Add support for v4.1.2. The settings should be adjusted accordingly.
Comment #16
anybodyPlease check if this is fixed with 4.x now.
Comment #17
anybody