Problem/Motivation

The label shown when hovering over the button to remove an abbreviation is not translated into the user's language.

Steps to reproduce

Assuming a standard Drupal installation, with a (interface) language that is not English and having this CKEditor Abbreviation module installed (of course):

  1. Ensure that the abbreviation plugin is attached to a CKEditor, e.g., by editing /admin/config/content/formats/manage/basic_html
  2. Create a node that has a text field with support for the CKEditor, e.g., /node/add/page.
  3. Hover over the button to insert an abbreviation and notice that regarding the language of the user interface, "Remove" is shown.

Proposed resolution

Use the Drupal.t functionality to also translate the "Remove" label.

Remaining tasks

  • Implement the proposed solution and create a merge request.
  • Review the merge request.

User interface changes

When a translation of the word "Remove" is available in Drupal in the user's language, the label shown when hovering over the remove button is displayed in the user's language.

Issue fork ckeditor_abbreviation-3475238

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

watergate created an issue. See original summary.

watergate opened merge request !9

watergate’s picture

watergate commented
Assigned: watergate » Unassigned
Issue summary: View changes
Status: Active » Needs review

I've opened the proposed merge request.

  • boromino committed c7be007d on 4.0.x 
    Issue #3475238 by watergate: Remove button label is not translated

  • boromino committed 0d4e00f4 on 5.0.x 
    Issue #3475238 by watergate: Remove button label is not translated
boromino’s picture

boromino commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

boromino closed merge request !9