Problem/Motivation

This module needs to be upgraded to allow for Drupal 11 compatibility

For sure fails with both changes needed to .info and from PHPStan

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress --error-format=gitlab > phpstan-quality-report.json || true
$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
 ------ ---------------------------------------------------------------------- 
  Line   src/Form/SettingsForm.php                                             
 ------ ---------------------------------------------------------------------- 
  44     Method Drupal\Core\Form\ConfigFormBase::__construct() invoked with 1  
         parameter, 2 required.                                                
 ------ ---------------------------------------------------------------------- 
 [ERROR] Found 1 error   

See this change record https://www.drupal.org/node/3404140

Pretty sure we can get away without overloading the constructor by using $this->container()->get('entity_type.manager') down where we are looking for it in buildForm.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

generalredneck created an issue. See original summary.

generalredneck’s picture

Issue summary: View changes

generalredneck’s picture

So container() is a private function, so I couldn't access it. That said, I had to increase the minimum requirements for this piece for Drupal 10.2. See the Change Record linked in the description.

I've tested this in both Drupal 10.3 and 11.0 and there were no problems. Gitlab_ci passed.

generalredneck’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.