Problem/Motivation

When #3452181: VariationCache needs to be more defensive about cache context manipulation to avoid broken redirects was merged caused some issues in the book module. This was fixed in contrib #3472014: BookBreadcrumbBuilder needs to always set the route.book_navigation cache context but needs to be fixed in 10.4.x branch for tests to run

Steps to reproduce

Proposed resolution

Use same solution.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3472592

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Version: 11.x-dev » 10.4.x-dev

smustgrave opened merge request !9437

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Tests green, same fix as here: https://www.drupal.org/project/book/issues/3472014

Looking good, RTBC,

bbrala’s picture

bbrala
Location Netherlands
commented
Related issues: +#3452181: VariationCache needs to be more defensive about cache context manipulation to avoid broken redirects
catch’s picture

catch
he/him
Primary language English
commented
Title: Fix Book so 10.4 tests will run » Fix Book breadcrumb cacheability

  • catch committed f781cd93 on 10.3.x 
    Issue #3472592 by smustgrave: Fix Book breadcrumb cacheability

(cherry...

  • catch committed 5eb99caa on 10.4.x 
    Issue #3472592 by smustgrave: Fix Book breadcrumb cacheability
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.4.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.4.x, thanks!

Since this is a straight bug-fix for book module, backported to 10.3.x, too.

gillesbailleux’s picture

gillesbailleux
Primary language French
Location La Roche-en-Ardenne
commented

Hello,

Since updating from D10.3.3 to D10.3.4, the nav-item active class of the menu is only active on the homepage. I looked in the changes of the release and found this book breadcrumb related issue. The website uses the bootstrap_barrio 5.5.17 theme and the menu was working just fine before the update.

Regards,

Gilles

gillesbailleux’s picture

gillesbailleux
Primary language French
Location La Roche-en-Ardenne
commented

As mentioned by smustgrave on Slack, there is no relation between the Book breadcrumb cacheability issue and the Bootstrap menu issue because the website does not have the Book module activated.

gillesbailleux’s picture

gillesbailleux
Primary language French
Location La Roche-en-Ardenne
commented

D10.3.5 solves the isssue I raised.
"This release reverts #3471741: Fix null $cid in CacheCollector classes, released in 10.3.4, which conflicted with Menu Trail by Path, Entity Manager and Gin Toolbar modules."

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.