GitLAb CI reports PHP_CodeSniffer errors/warnings and PHPStan errors which should be fixed.

Issue fork entity_submenu_block-3472324

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunil jolapara created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standard is not matched » Fix the issues reported by PHP_CodeSniffer
Version: 8.x-1.5 » 8.x-1.x-dev
Category: Bug report » Task
Status: Needs work » Active
Issue tags: -Drupal coding standard checks

avpaderno opened merge request !2

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Fix the issues reported by PHP_CodeSniffer » Add .gitlab-ci.yml
Status: Active » Reviewed & tested by the community
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Add .gitlab-ci.yml » Fix the issues reported by PHP_CodeSniffer
Status: Reviewed & tested by the community » Needs review

The task is fixing what reported by PHP_CodeSniffer. I added the .gitlab-ci.yml file to get a list of the PHP_CodeSniffer errors/warnings, which are still to be fixed.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @avpaderno - sorry I got that wrong, this looked inactive and the MR only contained that one change. Are you planning to finish this?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I will commit the fix in few minutes. The list of changes is not that long.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@avpaderno would make sense to also fix phpstan and phpcs here, wouldn't it? Then we're done!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@avpaderno I'm maintainer now, so once done I'd be happy to merge the fixed! :)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Fix the issues reported by PHP_CodeSniffer » Fix the issues reported by GitLAb CI
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Fix the issues reported by GitLAb CI » Fix the issues reported by GitLab CI
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

All the jobs pass.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

GREAT work avpaderno!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

  • anybody committed c25d655c on 8.x-1.x authored by avpaderno 
    Issue #3472324 by avpaderno: Fix the issues reported by GitLab CI

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.