Problem/Motivation

After updating to migrate_plus 6.0.4 there is an php error with the function declaration getSourceData.

PHP Fatal error: Declaration of Drupal\migrate_youtube\Plugin\migrate_plus\data_parser\YoutubeApiJson::getSourceData(string $url): array must be compatible with Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Json::getSourceData(string $url, string|int $item_selector = '') in /var/www/html/platforme-mediation/drupal/www/modules/contrib/migrate_youtube/src/Plugin/migrate_plus/data_parser/YoutubeApiJson.php on line 71

Steps to reproduce

CommentFileSizeAuthor
#2 fix_function_declaration_3470245.patch743 bytessmavri

Issue fork migrate_youtube-3470245

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smavri created an issue. See original summary.

smavri’s picture

smavri commented
StatusFileSize
new fix_function_declaration_3470245.patch743 bytes

Here is a patch

b2f’s picture

b2f commented

Hello,
Since I we know each others and worked together before, you are now co-maintainer of this project.

deepali sardana’s picture

deepali sardana commented
Assigned: Unassigned »

deepali sardana opened merge request !1

deepali sardana’s picture

deepali sardana commented
Assigned: » Unassigned

  • anfor committed 624f0c09 on 1.0.x 
    Issue #3470245 by smavri : PHP Fatal Error in getSourceData function
anfor’s picture

anfor commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anfor closed merge request !1

anfor’s picture

anfor commented
Status: Fixed » Closed (fixed)