Problem/Motivation

RFC accepted - https://wiki.php.net/rfc/deprecate-get-post-sessions

Deprecated session.use_only_cookies, session.use_trans_sid and session.referer_check see commit

Steps to reproduce

use git grep

core/lib/Drupal/Core/DrupalKernel.php:997:      ini_set('session.use_only_cookies', '1');
core/lib/Drupal/Core/DrupalKernel.php:998:      ini_set('session.use_trans_sid', '0');

Proposed resolution

do not change this settings on PHP 8.4

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3470075

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost opened merge request !9317

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
Related issues: +#3465836: PHP 8.4 session.sid_length and session.sid_bits_per_character are deprecated
ankitv18’s picture

ankitv18 commented

Mentioned on the php doc this deprecation will be removed from PHP 9.0 ~~ I think short comment with a link would be more ideal with this change.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs change record

Here should be CR and clean up of it will happen before 12.0

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: -Needs change record

CR created

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: PHP 8.4 session.use_only_cookies and session.use_trans_sid are deprecated » PHP 8.4 GET/POST sessions are deprecated
ankitv18’s picture

ankitv18 commented

Looks good but could make more sense if we add statement of removal of these variables from PHP 9 or something related

andypost’s picture

andypost
he/him
Primary language Russian
commented

updated CR, feel free to improve it and RTBC)

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Current revision looks much better as taking the reference form php.net, also changes looks quite straightforward ~~ hence marking this one as RTBC.

  • catch committed 763460d2 on 10.4.x 
    Issue #3470075 by andypost, ankitv18: PHP 8.4 GET/POST sessions are...

  • catch committed 68589170 on 11.x 
    Issue #3470075 by andypost, ankitv18: PHP 8.4 GET/POST sessions are...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Fixed

Looks good and we can just clean these up when we require PHP 8.4+ for Drupal 12. Committed/pushed to 11.x and cherry-picked to 10.4.x, thanks!

catch closed merge request !9317

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.