Problem/Motivation

Minor issue but interferes with the logic in #3465602: Order tests by number of public methods to optimize gitlab job times.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3469824

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

I think these traits are so old that they date from before we specified visibility on methods at all, then they probably got mass-updated to public at some point when we started. There's no reason for any class except child classes to call them.

catch opened merge request !9309

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward.

nod_ closed merge request !9309

  • nod_ committed 9746059c on 10.3.x 
    Issue #3469824 by catch, smustgrave: CommentTestBase/CommentTestTrait...

  • nod_ committed 092cf97b on 10.4.x 
    Issue #3469824 by catch, smustgrave: CommentTestBase/CommentTestTrait...

  • nod_ committed a5186f55 on 11.0.x 
    Issue #3469824 by catch, smustgrave: CommentTestBase/CommentTestTrait...

  • nod_ committed 5d987941 on 11.x 
    Issue #3469824 by catch, smustgrave: CommentTestBase/CommentTestTrait...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5d98794158 to 11.x and a5186f55c9 to 11.0.x and 092cf97bf2 to 10.4.x and 9746059c19 to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.