Drupal Version

11.x

Domain module version

2.0.x

Expected Behavior

Should install on Drupal 11.

Issue fork domain-3469505

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

agentrickard created an issue. See original summary.

agentrickard opened merge request !102

  • agentrickard committed ba2444d2 on 2.0.x 
    Issue #3469505 by agentrickard: Mark as Drupal 11 compatible
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Fixed
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Fixed » Needs work

This is actually throwing test fails that need to be addressed before release.

agentrickard opened merge request !103

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

The test fails are specific to GitLab behavior and I have filed an issue #3469521: Drupal 11 requires root info.yml file and breaks existing module tests

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs work » Needs review

Should it be merged or are there any steps missing? Let me know if there is anything left to do.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Needs work

I merged that D11 compatibility already (MR 102). This is open to try to resolve the GItLab CI issues with OPT_IN_NEXT_VERSION (d11) testing (MR 103).

Specifically #3469536: Test was run in child process and ended unexpectedly -- PHPUnit simply isn't running properly under the D11 (OPT_IN_NEXT_VERSION) step.

If you want to close this and open a new tracking issue, that's fine.

davps made their first commit to this issue’s fork.

davps’s picture

davps commented
Status: Needs work » Needs review

All jobs are green and passed now.

Comments on changes:

- default_argument_skip_url: *
The Views setting default_argument_skip_url has been removed since version 10.2.0 - https://www.drupal.org/node/3382316

Test was run in child process and ended unexpectedly
The reason why the tests failed was because the test couldn't enable the module due to a change in the constructor parameter declaration - https://git.drupalcode.org/project/domain/-/jobs/2511587#L57

	scanDirectories:
		- ../../../../vendor/drush/drush/src-symfony-compatibility

Fix for https://git.drupalcode.org/project/domain/-/jobs/2511587#L47

webflo made their first commit to this issue’s fork.

webflo’s picture

webflo commented
Status: Needs review » Fixed

Committed to 2.0.x

webflo’s picture

webflo commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.