Problem/Motivation

This tests has 14 methods and can take a couple of minutes to run, about 1m43s locally. We can consolidate several of the test methods into one test case (although leaving them as protected methods for readability) to cut down on the number of Drupal installs/setup tasks. A couple of changes needed to reset state but not too bad.

Steps to reproduce

After:

Time: 00:37.483, Memory: 6.00 MB

OK (5 tests, 193 assertions)

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3469335

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

catch’s picture

Status: Active » Needs review

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seems straight forward, no coverage lost.

  • nod_ committed 7f5d19e9 on 10.3.x
    Issue #3469335 by catch, smustgrave: Speed up PageCacheTest
    
    (cherry...

  • nod_ committed 87e995ed on 10.4.x
    Issue #3469335 by catch, smustgrave: Speed up PageCacheTest
    
    (cherry...

  • nod_ committed 89f81f39 on 11.0.x
    Issue #3469335 by catch, smustgrave: Speed up PageCacheTest
    
    (cherry...

  • nod_ committed de6e4c69 on 11.x
    Issue #3469335 by catch, smustgrave: Speed up PageCacheTest
    
nod_’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed de6e4c69e5 to 11.x and 89f81f39b3 to 11.0.x and 87e995edfe to 10.4.x and 7f5d19e93f to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.