Problem/Motivation

Make the module drupal 11 compatible.

Steps to reproduce

Proposed resolution

Make the module drupal 11 compatible.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drowl_admin-3468929

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

grevil opened merge request !10

grevil’s picture

grevil commented

The last compatibility fix needs to be done by @thomas.frobieter:

Check manually 0    The #drupal-off-canvas selector is deprecated in
                    drupal:9.5.0 and is removed from drupal:10.0.0. See
                    https://www.drupal.org/node/3305664.
--------------------------------------------------------------------------------

In https://www.drupal.org/node/3305664 is written, that instead of using the old #drupal-off-canvas id, #drupal-off-canvas-wrapper should be used, but we are using both in code, so I am unsure, whether to remove the #drupal-off-canvas or merge it together with the #drupal-off-canvas-wrapper part.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Re #off-canvas we can ignore that. It won't have any bad effects, just a nice reminder from Drupal. I guess we're not even using this any more?

So I think you can merge this and @thomas.frobieter can have a short look if it's fine like this. We shouldn't block this on that crap ;)

grevil’s picture

grevil commented

We ARE using it, but we have both #drupal-off-canvas-wrapper and #drupal-off-canvas, with different css classes etc. set

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Yeah I mean just in CSS, doesn't do any harm.

  • Anybody committed 65c9a95a on 3.x authored by grevil 
    Issue #3468929 by grevil: Make module0Drupal 11 compatible
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: thomas.frobieter » Unassigned
Status: Active » Fixed

Merged. @thomas.frobieter please comment and reopen if you disagree.

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented

Oh, "module0" sounds fancy, what's that? ;D

Yes, we can safely ignore this warning about the #off-canvas selector.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Make module0Drupal 11 compatible » Make drowl_admin Drupal 11 compatible

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.