Problem/Motivation

An old workaround prevents identifying risky functional tests.

UiHelperTrait::assertSession() now adds to the assertion count so the workaround to add an assertion at setUp() can be temoved.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3468204

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !9215

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
Status: Active » Needs review
mstrelan’s picture

mstrelan commented

I guess this could cause risky tests in contrib, so might need a CR?

mondrake’s picture

mondrake
Location 🇮🇹
commented

Added this issue to CR https://www.drupal.org/node/3467095

I think that is enough

mstrelan’s picture

mstrelan commented
Status: Needs review » Reviewed & tested by the community

  • longwave committed c17cc49d on 11.x 
    Issue #3468204 by mondrake, mstrelan: Remove assertion workaround from...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Great to see this hack be removed, surprised there was only one fix needed.

Not eligible for backport as it may affect contrib tests as per #4.

Committed c17cc49 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake closed merge request !9215