Problem/Motivation

There are a few coding standards violations.

Steps to reproduce

Proposed resolution

Fix them.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 phpmailer--smtp--issues--3467952.png26.44 KBbhaveshdas

Issue fork phpmailer_smtp-3467952

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

imclean created an issue. See original summary.

sarwan_verma made their first commit to this issue’s fork.

sarwan_verma opened merge request !4

sarwan_verma’s picture

sarwan_verma commented
Status: Active » Needs review

I have resolved the "Coding standards issues" and created MR!4,
kindly review it,
thanks!.

bhaveshdas’s picture

bhaveshdas commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new phpmailer--smtp--issues--3467952.png26.44 KB

Hi, I have tested MR!4 and it is working properly with no errors found. I will move it forward to RTBC.

Screenshots are attached for reference.

Hence it can be move to the RTBC.
RTBC+1

Thankyou !!

imclean’s picture

imclean commented
Status: Reviewed & tested by the community » Needs work

Added comment in MR.

  • imclean committed df528a84 on 2.3.x 
    Issue #3467952: Coding standards issues
imclean’s picture

imclean commented
Status: Needs work » Fixed

Committed to 2.3.x along with some other minor tidying. Markdown in Drupal doesn't yet have coding standards: #2952616: Adopt CommonMark spec for Markdown files

imclean’s picture

imclean commented
Status: Fixed » Closed (fixed)