Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
cspell shows unrecognized words:
=== This is _cspell_unrecognized_words.txt ===
Overriden
Piskarov
preven
phpstan shows
------ --------------------------------------------------------------------
Line tests/src/Functional/AdvupdateTest.php
------ --------------------------------------------------------------------
33 You should use assertTrue() instead of assertSame() when expecting
"true"
------ --------------------------------------------------------------------
[ERROR] Found 1 error
Steps to reproduce
Run testing pipeline against code:
https://git.drupalcode.org/project/advupdate/-/pipelines/173262
Proposed resolution
Add .cspell-project-words.txt with Piskarov in it. Fix the others.
Change the assert.
Make Drupal 11 release. Test against Drupal 11.
Remaining tasks
Make Drupal 11 release as code is compatible: #3442407: Automated Drupal 11 compatibility fixes for advupdate
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Issue fork advupdate-3466888
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
elc commentedFixes trivial issues.
The tests need better coverage of module functionality. Current tests consist of:
- that an installed setting does get installed
- that the anonymous user cannot access the settings page
Testing rig is experiencing issues at present.
Comment #5
ruslan piskarovComment #6
ruslan piskarovThank you, ELC. It was merged into DEV. I will have a look later.
Regarding to tests. Currently, I don't have free time to write this today. I am in Ukraine, and I have other priorities. If someone is willing and able to do it, I appreciate it more.
Comment #7
ruslan piskarov