Problem/Motivation

When running ci tests during merge requests errors are reported classes from facets and search_api are missing.
Matomo should declare a dependency on both modules.

------ ---------------------------------------------------------------------- 
  Line   src/HookHandler/ViewsPostRenderHookHandler.php                        
 ------ ---------------------------------------------------------------------- 
  36     Property                                                              
         Drupal\matomo\HookHandler\ViewsPostRenderHookHandler::$facetsManager  
         has unknown class Drupal\facets\FacetManager\DefaultFacetManager as   
         its type.                                                             
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
  48     Parameter $facetsManager of method                                    
         Drupal\matomo\HookHandler\ViewsPostRenderHookHandler::__construct()   
         has invalid type Drupal\facets\FacetManager\DefaultFacetManager.      
  214    Class Drupal\search_api\Plugin\views\query\SearchApiQuery not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/views/display_extender/Matomo.php                          
 ------ ---------------------------------------------------------------------- 
  47     Property                                                              
         Drupal\matomo\Plugin\views\display_extender\Matomo::$facetsManager    
         has unknown class Drupal\facets\FacetManager\DefaultFacetManager as   
         its type.                                                             
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
  160    Class Drupal\search_api\Plugin\views\query\SearchApiQuery not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ ----------------------------------------------------------------------

Steps to reproduce

Run a merge request on this project.

Proposed resolution

Add a test_dependency on search_api and facets

Issue fork matomo-3466869

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kriboogh created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Those dev dependencies had been added on 2.0.x.

Adding on 8.x-1.x

grimreaper opened merge request !84

  • grimreaper committed 2dd93d08 on 8.x-1.x 
    fix: #3466869 Dependency on facets and search_api

By: kriboogh
By:...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.