Problem/Motivation

ManageFieldsFunctionalTest is very old and one of the very longest running functional tests at more than three minutes.

We don't need ::testDeleteTaxonomyField() when we have the dedicated FieldUIDeleteTest that does a lot more. Ideally all of this would use entity_test instead of taxonomy and node modules but that would be a much bigger refactoring.

A couple of test methods can also be combined into one as well which will reduce runtime while still testing similar functionality.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3465968

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

catch’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward.

  • nod_ committed 4b221d55 on 10.3.x
    Issue #3465968 by catch: De-duplicate logic in...

  • nod_ committed 77b90367 on 10.4.x
    Issue #3465968 by catch: De-duplicate logic in...

  • nod_ committed 6b661927 on 11.0.x
    Issue #3465968 by catch: De-duplicate logic in...

  • nod_ committed 71ae8fcb on 11.x
    Issue #3465968 by catch: De-duplicate logic in...
nod_’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 71ae8fcb3a to 11.x and 6b66192717 to 11.0.x and 77b9036719 to 10.4.x and 4b221d555b to 10.3.x. Thanks!

nod_’s picture

Version: 11.x-dev » 10.3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.