Problem/Motivation

With drupal 10, when the user login failed, it will trigger flood control. When the flood control is active, it did not set $form_state error, it directly return 403 response, hence to accomodate this, alogin.module should validate against $form_state->get('uid') along with $form_state->getErrors();

Steps to reproduce

Enable the flood control, set limit to 3 or 5, try to login using wrong password. Once the flood control triggered, you will have the user logged in

Proposed resolution

alogin.module alogin_ajax_callback should validate for presence of $form_state->get('uid') and $form_state->getErrors()

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork alogin-3465864

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

herdianf created an issue. See original summary.

ahmed.raza’s picture

Status: Active » Fixed
ahmed.raza’s picture

Status: Fixed » Active
rohan_singh’s picture

Assigned: Unassigned » rohan_singh

i'll look into this.

rohan_singh’s picture

Assigned: rohan_singh » Unassigned
Status: Active » Needs review

Hi @ahmed.raza, I was able to reproduce the issue and created an MR for the same.
Please review.

Thanks,
Rohan Singh

dhruv.mittal changed the visibility of the branch 3465864-should-check-for to hidden.

dhruv.mittal changed the visibility of the branch 3465864-should-check-for to hidden.

dhruv.mittal changed the visibility of the branch 3465864-should-check-for to active.

dhruv.mittal’s picture

Status: Needs review » Reviewed & tested by the community

I have followed the steps to reproduce , successfully reproduce the issue and applied the MR !8 , it is resolving the issue so moving it to RTBC
And sorry I have mistakenly hide the MR!8.

  • rohan_singh authored 2586d63f on 2.1.x
    Issue #3465864: Fixed the compatibility issue with flood control module.
    
ahmed.raza’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the MR @Rohan, its merged and releases in ^2.1.4.

ahmed.raza’s picture

Status: Fixed » Closed (fixed)