Problem/Motivation
Steps to reproduce
Proposed resolution
Use BS utility classes: https://getbootstrap.com/docs/5.3/utilities/flex/#justify-content
Not sure how to handle older drowl_base theme versions (Foundation). => They need to override the templates, like mentioned on the module page.
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork drowl_media-3465770
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
thomas.frobieterComment #3
thomas.frobieterComment #4
thomas.frobieterAs mentioned in the module description, we use Bootstrap classes - old (Foundation based) themes will need to override the affected media templates.
Comment #5
thomas.frobieter@anybody: We hide overlay fields, when "no overlay" is selected (States API). Could you please remove this? It doesnt make sense, since we can disable the overlay for specific breakpoints.
The trigger field is: field_overlay_position, please fix it right here in the issue fork so we dont run into merge conflict ..things.
Comment #6
thomas.frobieterComment #7
thomas.frobieter@anybody: Okay.. there are still fields that should be hidden by States API, so more explicit.. never hide those three:
- field_overlay_display
- field_overlay_button_color
- field_overlay_button_style
While:
- field-overlay-sizing should be hidden when field-overlay-position is set to "disabled" (or unset) => this is already the case
- field_overlay_sizing_md should be hidden when field_overlay_position_md is set to "disabled" (or unset)
- field_overlay_sizing_lg should be hidden when field_overlay_position_lg is set to "disabled" (or unset)
Comment #8
thomas.frobieterComment #9
anybodyComment #10
thomas.frobieterThe field states are managed in the wrong module (drowl_header_slides), it doesn't matter if the media slide is a "header slide", a hero or a regular slide.
I'll move it over, so we can finish and release this.
Comment #11
thomas.frobieterDone. Please review @anybody, I'll create a new release afterwards.
I also create a new release of drowl_header_slides without the media slide form fields states stuff.
I'll create another task for the required configuration update, which is not that important.
Comment #13
anybodyLooks good, the following things should be done before merging this:
1. Use the empty value instead of "disabled" string for the disabled option
2. Add the configuration updates here, or it will never happen, which will screw up existing projects
I didn't test it myself, just had a look at the states API code.
Comment #14
thomas.frobieterSee #3497194: Make media-slide overlay responsive settings mandatory and provide default values, so we dont have an empty value anymore after this change.
I don't think we have any configuration updates.
Comment #15
anybodyOk then I got that wrong. If it works fine for you. it's fine for me!
Comment #17
thomas.frobieterMerged! thx!