Problem/Motivation

One of the longest running FunctionalJavascript tests: https://git.drupalcode.org/project/drupal/-/jobs/2232668

Steps to reproduce

Proposed resolution

Have to do a small amount of extra work to avoid creating duplicate fields, but overall test logic is unchanged otherwise.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3463908

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Title: Stop using a data provider in OptionsFieldUiTest » Split OptionsFieldUiTest into two
Status: Active » Needs review

Tried removing the data provider but there's a lot of field/entity state to keep track of if we do that.

So trying the brute force approach of splitting this into two classes - one for the data provider test, one for the other test methods.

catch opened merge request !8935

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straightforward

quietone made their first commit to this issue’s fork.

quietone’s picture

quietone commented

I changed the class doc for the new test file to show what it is doing. Leaving at RTBC.

pooja_sharma’s picture

pooja_sharma commented

Observed test failures, found there are some Nightwatch test case failures unrelated to changes in MR & run pipeline

pipeline passed & MR is mergeable now, keeping it to prev RTBC state.

nod_ closed merge request !8935

  • nod_ committed b2fc85cf on 10.3.x 
    Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two

(...

  • nod_ committed cbea2bb9 on 10.4.x 
    Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two

(...

  • nod_ committed a73cec5d on 11.0.x 
    Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two

(...

  • nod_ committed a2713312 on 11.x 
    Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed a2713312d2 to 11.x and a73cec5df8 to 11.0.x and cbea2bb9af to 10.4.x and b2fc85cf0b to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.