Problem/Motivation

Moving to selenium has exposed a problem with the statusMessageExists() assertion. It does not wait - if the message is added by ajax there's no guarantee the message is there yet. See https://git.drupalcode.org/project/drupal/-/jobs/2218322

Steps to reproduce

See https://git.drupalcode.org/project/drupal/-/jobs/2218322

Proposed resolution

I think this method should do a wait if used in a JS test.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

None

Issue fork drupal-3463594

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !8914

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Can this be backport all the way to 10.x - there's no harm and it'll help backporting the W3C issue.

catch’s picture

catch
he/him
Primary language English
commented

Yeah I think we could go back to 10.3.x with this, just method overrides to fix a bug.

  • catch committed b200582f on 10.3.x 
    Issue #3463594 by alexpott: ImageAdminStylesTest::...

  • catch committed 1a97c700 on 10.4.x 
    Issue #3463594 by alexpott: ImageAdminStylesTest::...

  • catch committed dd1cf47d on 11.0.x 
    Issue #3463594 by alexpott: ImageAdminStylesTest::...

  • catch committed 6a0c12a6 on 11.x 
    Issue #3463594 by alexpott: ImageAdminStylesTest::...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Going to go ahead here to stabilise core test runs even though I RTBCed it.

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

catch closed merge request !8914

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.